This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Generic GHA to sync dists with gh releases #434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ipfs/distributions#503
This PR was extracted out of #262
Description
go-ipfs/sync-release-assets.yml and go-libp2p-relay-daemon/sync-release-assets.yml are almost identical. The only difference between the two is the name of the distribution that they are syncing. That's why I want to turn
sync-release-assets.ymlinto a reusable workflow living inprotocol/.githubrepository that takesdistas an input parameter(https://github.com/protocol/.github/blob/486f183d83a80dd1a48589b8bfbf1672f8167064/.github/workflows/sync-release-assets.yml).I also want to use the unified CI framework to copy the concrete workflow(the one that is going to be using the reusable workflow) to both
go-ipfsandgo-libp2p-relay-daemonrepositories.Thanks to #262, we can create a
sync-release-assets.ymltemplate(.github/templates/.github/workflows/sync-release-assets.yml
Line 11 in 486f183
distvalue fromconfig(.github/configs/go.json
Line 62 in 486f183
Testing
.github-test-targetfrom testing: dispatch + copy-workflow + PR